On 29.08.2018 10:56, kostap@marvell.com wrote:
From: Ofer Heifetz oferh@marvell.com
This commit is needed to properly support the 8-bits ECC configuration with 4KB pages.
When pages larger than 2 KB are used on platforms using the PXA3xx NAND controller, the reading/programming operations need to be split in chunks of 2 KBs or less because the controller FIFO is limited to about 2 KB (i.e a bit more than 2 KB to accommodate OOB data). Due to this requirement, the data layout on NAND is a bit strange, with ECC interleaved with data, at the end of each chunk.
When a 4-bits ECC configuration is used with 4 KB pages, the physical data layout on the NAND looks like this:
| 2048 data | 32 spare | 30 ECC | 2048 data | 32 spare | 30 ECC |
So the data chunks have an equal size, 2080 bytes for each chunk, which the driver supports properly.
When a 8-bits ECC configuration is used with 4KB pages, the physical data layout on the NAND looks like this:
| 1024 data | 30 ECC | 1024 data | 30 ECC | 1024 data | 30 ECC | 1024 data | 30 ECC | 64 spare | 30 ECC |
So, the spare area is stored in its own chunk, which has a different size than the other chunks. Since OOB is not used by UBIFS, the initial implementation of the driver has chosen to not support reading this additional "spare" chunk of data.
Unfortunately, Marvell has chosen to store the BBT signature in the OOB area. Therefore, if the driver doesn't read this spare area, Linux has no way of finding the BBT. It thinks there is no BBT, and rewrites one, which U-Boot does not recognize, causing compatibility problems between the bootloader and the kernel in terms of NAND usage.
To fix this, this commit implements the support for reading a partial last chunk. This support is currently only useful for the case of 8 bits ECC with 4 KB pages, but it will be useful in the future to enable other configurations such as 12 bits and 16 bits ECC with 4 KB pages, or 8 bits ECC with 8 KB pages, etc. All those configurations have a "last" chunk that doesn't have the same size as the other chunks.
In order to implement reading of the last chunk, this commit:
Adds a number of new fields to the pxa3xx_nand_info to describe how many full chunks and how many chunks we have, the size of full chunks and partial chunks, both in terms of data area and spare area.
Fills in the step_chunk_size and step_spare_size variables to describe how much data and spare should be read/written for the current read/program step.
Reworks the state machine to accommodate doing the additional read or program step when a last partial chunk is used.
This commit is taken from Linux: 'commit c2cdace755b' ("mtd: nand: pxa3xx_nand: add support for partial chunks")
Signed-off-by: Chris Packham judge.packham@gmail.com Signed-off-by: Ofer Heifetz oferh@marvell.com Reviewed-by: Igal Liberman igall@marvell.com Cc: Stefan Roese sr@denx.de Cc: Simon Glass sjg@chromium.org
drivers/mtd/nand/pxa3xx_nand.c | 154 ++++++++++++++++++++++++++--------------- 1 file changed, 99 insertions(+), 55 deletions(-)
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index 4faf787..5cc75de 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c +++ b/drivers/mtd/nand/pxa3xx_nand.c @@ -201,15 +201,44 @@ struct pxa3xx_nand_info { int use_spare; /* use spare ? */ int need_wait;
- unsigned int data_size; /* data to be read from FIFO */
- unsigned int chunk_size; /* split commands chunk size */
- unsigned int oob_size;
/* Amount of real data per full chunk */
unsigned int chunk_size;
/* Amount of spare data per full chunk */ unsigned int spare_size;
/* Number of full chunks (i.e chunk_size + spare_size) */
unsigned int nfullchunks;
/*
* Total number of chunks. If equal to nfullchunks, then there* are only full chunks. Otherwise, there is one last chunk of* size (last_chunk_size + last_spare_size)*/unsigned int ntotalchunks;
/* Amount of real data in the last chunk */
unsigned int last_chunk_size;
/* Amount of spare data in the last chunk */
unsigned int last_spare_size;
unsigned int ecc_size; unsigned int ecc_err_cnt; unsigned int max_bitflips; int retcode;
/*
* Variables only valid during command* execution. step_chunk_size and step_spare_size is the* amount of real data and spare data in the current* chunk. cur_chunk is the current chunk being* read/programmed.*/unsigned int step_chunk_size;
unsigned int step_spare_size;
unsigned int cur_chunk;
/* cached register value */ uint32_t reg_ndcr; uint32_t ndtr0cs0;
@@ -436,25 +465,6 @@ static int pxa3xx_nand_init_timings(struct pxa3xx_nand_host *host) return 0; }
-/*
- Set the data and OOB size, depending on the selected
- spare and ECC configuration.
- Only applicable to READ0, READOOB and PAGEPROG commands.
- */
-static void pxa3xx_set_datasize(struct pxa3xx_nand_info *info,
struct mtd_info *mtd)-{
- int oob_enable = info->reg_ndcr & NDCR_SPARE_EN;
- info->data_size = mtd->writesize;
- if (!oob_enable)
return;- info->oob_size = info->spare_size;
- if (!info->use_ecc)
info->oob_size += info->ecc_size;-}
- /**
- NOTE: it is a must to set ND_RUN first, then write
- command buffer, otherwise, it does not work.
@@ -535,39 +545,38 @@ static void drain_fifo(struct pxa3xx_nand_info *info, void *data, int len)
static void handle_data_pio(struct pxa3xx_nand_info *info) {
- unsigned int do_bytes = min(info->data_size, info->chunk_size);
- switch (info->state) { case STATE_PIO_WRITING:
writesl(info->mmio_base + NDDB,info->data_buff + info->data_buff_pos,DIV_ROUND_UP(do_bytes, 4));
if (info->step_chunk_size)writesl(info->mmio_base + NDDB,info->data_buff + info->data_buff_pos,DIV_ROUND_UP(info->step_chunk_size, 4));
if (info->oob_size > 0)
if (info->step_spare_size) writesl(info->mmio_base + NDDB, info->oob_buff + info->oob_buff_pos,
DIV_ROUND_UP(info->oob_size, 4));
DIV_ROUND_UP(info->step_spare_size, 4));
drain_fifo(info,info->data_buff + info->data_buff_pos,DIV_ROUND_UP(do_bytes, 4));
if (info->step_chunk_size)drain_fifo(info,info->data_buff + info->data_buff_pos,DIV_ROUND_UP(info->step_chunk_size, 4));
if (info->oob_size > 0)
if (info->step_spare_size) drain_fifo(info, info->oob_buff + info->oob_buff_pos,
DIV_ROUND_UP(info->oob_size, 4));
DIV_ROUND_UP(info->step_spare_size, 4));
info->state);
info->state);BUG(); }
/* Update buffer pointers for multi-page read/write */
- info->data_buff_pos += do_bytes;
- info->oob_buff_pos += info->oob_size;
- info->data_size -= do_bytes;
info->data_buff_pos += info->step_chunk_size;
info->oob_buff_pos += info->step_spare_size; }
static void pxa3xx_nand_irq_thread(struct pxa3xx_nand_info *info)
@@ -701,9 +710,11 @@ static void prepare_start_command(struct pxa3xx_nand_info *info, int command) /* reset data and oob column point to handle data */ info->buf_start = 0; info->buf_count = 0;
- info->oob_size = 0; info->data_buff_pos = 0; info->oob_buff_pos = 0;
- info->step_chunk_size = 0;
- info->step_spare_size = 0;
- info->cur_chunk = 0; info->use_ecc = 0; info->use_spare = 1; info->retcode = ERR_NONE;
@@ -715,8 +726,6 @@ static void prepare_start_command(struct pxa3xx_nand_info *info, int command) case NAND_CMD_READ0: case NAND_CMD_PAGEPROG: info->use_ecc = 1;
- case NAND_CMD_READOOB:
pxa3xx_set_datasize(info, mtd);@@ -773,6 +782,14 @@ static int prepare_set_command(struct pxa3xx_nand_info *info, int command, if (command == NAND_CMD_READOOB) info->buf_start += mtd->writesize;
if (info->cur_chunk < info->nfullchunks) {info->step_chunk_size = info->chunk_size;info->step_spare_size = info->spare_size;} else {info->step_chunk_size = info->last_chunk_size;info->step_spare_size = info->last_spare_size;}- /*
- Multiple page read needs an 'extended command type' field,
- which is either naked-read or last-read according to the
@@ -784,8 +801,8 @@ static int prepare_set_command(struct pxa3xx_nand_info *info, int command, info->ndcb0 |= NDCB0_DBC | (NAND_CMD_READSTART << 8) | NDCB0_LEN_OVRD | NDCB0_EXT_CMD_TYPE(ext_cmd_type);
info->ndcb3 = info->chunk_size +info->oob_size;
info->ndcb3 = info->step_chunk_size +info->step_spare_size;}
set_command_address(info, mtd->writesize, column, page_addr);
@@ -805,8 +822,6 @@ static int prepare_set_command(struct pxa3xx_nand_info *info, int command, | NDCB0_EXT_CMD_TYPE(ext_cmd_type) | addr_cycle | command;
/* No data transfer in this case */info->data_size = 0; exec_cmd = 1;@@ -818,6 +833,14 @@ static int prepare_set_command(struct pxa3xx_nand_info *info, int command, break; }
if (info->cur_chunk < info->nfullchunks) {info->step_chunk_size = info->chunk_size;info->step_spare_size = info->spare_size;} else {info->step_chunk_size = info->last_chunk_size;info->step_spare_size = info->last_spare_size;}- /* Second command setting for large pages */ if (mtd->writesize > PAGE_CHUNK_SIZE) { /*
@@ -828,14 +851,14 @@ static int prepare_set_command(struct pxa3xx_nand_info *info, int command, info->ndcb0 |= NDCB0_CMD_TYPE(0x1) | NDCB0_LEN_OVRD | NDCB0_EXT_CMD_TYPE(ext_cmd_type);
info->ndcb3 = info->chunk_size +info->oob_size;
info->ndcb3 = info->step_chunk_size +info->step_spare_size; /* * This is the command dispatch that completes a chunked * page program operation. */
if (info->data_size == 0) {
if (info->cur_chunk == info->ntotalchunks) { info->ndcb0 = NDCB0_CMD_TYPE(0x1) | NDCB0_EXT_CMD_TYPE(ext_cmd_type) | command;@@ -862,7 +885,7 @@ static int prepare_set_command(struct pxa3xx_nand_info *info, int command, | command; info->ndcb1 = (column & 0xFF); info->ndcb3 = INIT_BUFFER_SIZE;
info->data_size = INIT_BUFFER_SIZE;
info->step_chunk_size = INIT_BUFFER_SIZE;break;
case NAND_CMD_READID:
@@ -872,7 +895,7 @@ static int prepare_set_command(struct pxa3xx_nand_info *info, int command, | command; info->ndcb1 = (column & 0xFF);
info->data_size = 8;
info->step_chunk_size = 8;@@ -880,7 +903,7 @@ static int prepare_set_command(struct pxa3xx_nand_info *info, int command, | NDCB0_ADDR_CYC(1) | command;
info->data_size = 8;
info->step_chunk_size = 8;break;
case NAND_CMD_ERASE1:
@@ -1064,22 +1087,31 @@ static void nand_cmdfunc_extended(struct mtd_info *mtd, } }
/* Only a few commands need several steps */if (command != NAND_CMD_PAGEPROG &&command != NAND_CMD_READ0 &&command != NAND_CMD_READOOB)break;info->cur_chunk++;- /* Check if the sequence is complete */
if (info->data_size == 0 && command != NAND_CMD_PAGEPROG)
if (info->cur_chunk == info->ntotalchunks &&command != NAND_CMD_PAGEPROG) break;/*
- After a splitted program command sequence has issued
- the command dispatch, the command sequence is complete.
*/
if (info->data_size == 0 &&
if (info->cur_chunk == (info->ntotalchunks + 1) &&command == NAND_CMD_PAGEPROG && ext_cmd_type == EXT_CMD_TYPE_DISPATCH) break;
if (command == NAND_CMD_READ0 || command == NAND_CMD_READOOB) { /* Last read: issue a 'last naked read' */
if (info->data_size == info->chunk_size)
if (info->cur_chunk == info->ntotalchunks - 1) ext_cmd_type = EXT_CMD_TYPE_LAST_RW; else ext_cmd_type = EXT_CMD_TYPE_NAKED_RW;@@ -1089,7 +1121,7 @@ static void nand_cmdfunc_extended(struct mtd_info *mtd, * the command dispatch must be issued to complete. */ } else if (command == NAND_CMD_PAGEPROG &&
info->data_size == 0) {
info->cur_chunk == info->ntotalchunks) { ext_cmd_type = EXT_CMD_TYPE_DISPATCH;@@ -1316,6 +1348,8 @@ static int pxa_ecc_init(struct pxa3xx_nand_info *info, int strength, int ecc_stepsize, int page_size) { if (strength == 1 && ecc_stepsize == 512 && page_size == 2048) {
info->nfullchunks = 1;info->ntotalchunks = 1;@@ -1324,6 +1358,8 @@ static int pxa_ecc_init(struct pxa3xx_nand_info *info, ecc->strength = 1;
} else if (strength == 1 && ecc_stepsize == 512 && page_size == 512) {
info->nfullchunks = 1;info->ntotalchunks = 1;@@ -1337,6 +1373,8 @@ static int pxa_ecc_init(struct pxa3xx_nand_info *info, */ } else if (strength == 4 && ecc_stepsize == 512 && page_size == 2048) { info->ecc_bch = 1;
info->nfullchunks = 1;info->ntotalchunks = 1;@@ -1347,6 +1385,8 @@ static int pxa_ecc_init(struct pxa3xx_nand_info *info,
} else if (strength == 4 && ecc_stepsize == 512 && page_size == 4096) { info->ecc_bch = 1;
info->nfullchunks = 2;info->ntotalchunks = 2;@@ -1361,8 +1401,12 @@ static int pxa_ecc_init(struct pxa3xx_nand_info *info, */ } else if (strength == 8 && ecc_stepsize == 512 && page_size == 4096) { info->ecc_bch = 1;
info->nfullchunks = 4;info->ntotalchunks = 5;info->last_chunk_size = 0;info->last_spare_size = 64;
Applied to u-boot-marvell/master
Thanks, Stefan