Hi Jassi,
On Fri, Dec 02, 2022 at 09:17:12PM -0600, jassisinghbrar@gmail.com wrote:
From: Jassi Brar jaswinder.singh@linaro.org
Moving towards using common code for meta-data management, implement the read/write mdata hooks.
Signed-off-by: Jassi Brar jaswinder.singh@linaro.org
drivers/fwu-mdata/gpt_blk.c | 40 +++++++++++++++++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-)
diff --git a/drivers/fwu-mdata/gpt_blk.c b/drivers/fwu-mdata/gpt_blk.c index 28f5d23e1e..35239c0a4f 100644 --- a/drivers/fwu-mdata/gpt_blk.c +++ b/drivers/fwu-mdata/gpt_blk.c @@ -222,7 +222,7 @@ static int fwu_gpt_read_mdata_partition(struct udevice *dev, struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
return gpt_read_write_mdata(dev_get_uclass_plat(priv->blk_dev),
mdata, MDATA_READ, part_num);
mdata, MDATA_READ, part_num);
I assume this was by mistake?
}
static int fwu_gpt_write_mdata_partition(struct udevice *dev, @@ -231,7 +231,7 @@ static int fwu_gpt_write_mdata_partition(struct udevice *dev, struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
return gpt_read_write_mdata(dev_get_uclass_plat(priv->blk_dev),
mdata, MDATA_WRITE, part_num);
mdata, MDATA_WRITE, part_num);
ditto
}
static int fwu_get_mdata_device(struct udevice *dev, struct udevice **mdata_dev) @@ -272,7 +272,43 @@ static int fwu_mdata_gpt_blk_probe(struct udevice *dev) return 0; }
+static int fwu_gpt_read_mdata(struct udevice *dev, struct fwu_mdata *mdata,
bool primary)+{
- struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
- struct blk_desc *desc = dev_get_uclass_plat(priv->blk_dev);
- int ret;
- ret = gpt_get_mdata_partitions(desc);
- if (ret < 0) {
log_debug("Error getting the FWU metadata partitions\n");return -ENOENT;- }
- return gpt_read_write_mdata(desc, mdata, MDATA_READ,
primary ? g_mdata_part[0] : g_mdata_part[1]);+}
+static int fwu_gpt_write_mdata(struct udevice *dev, struct fwu_mdata *mdata,
bool primary)+{
- struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
- struct blk_desc *desc = dev_get_uclass_plat(priv->blk_dev);
- int ret;
- ret = gpt_get_mdata_partitions(desc);
- if (ret < 0) {
log_debug("Error getting the FWU metadata partitions\n");return -ENOENT;- }
- return gpt_read_write_mdata(desc, mdata, MDATA_WRITE,
primary ? g_mdata_part[0] : g_mdata_part[1]);+}
static const struct fwu_mdata_ops fwu_gpt_blk_ops = {
- .read_mdata = fwu_gpt_read_mdata,
- .write_mdata = fwu_gpt_write_mdata, .get_mdata = fwu_gpt_get_mdata, .update_mdata = fwu_gpt_update_mdata, .get_mdata_part_num = fwu_gpt_get_mdata_partitions,
-- 2.34.1
Other than that Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org