-----Original Message----- From: Vladimir Oltean vladimir.oltean@nxp.com Sent: Thursday, December 2, 2021 8:24 PM To: u-boot@lists.denx.de Cc: Michael Walle michael@walle.cc; Tom Rini trini@konsulko.com; Priyanka Jain priyanka.jain@nxp.com; Leo Li leoyang.li@nxp.com; Ramon Fried rfried.dev@gmail.com Subject: [PATCH 10/15] arm: dts: ls1028a-rdb: sync Ethernet device tree nodes with Linux
In a bit of a blunder, the blamed commit made the mscc_felix switch driver
Please be specific about which commit
look at the 'managed = "in-band-status"' device tree property, forgetting that the U-Boot device tree had not been updated to include that property, whereas the Linux one does.
The switch is therefore described in the device tree as not requiring in-band autoneg, but the PHY driver for VSC8514 (drivers/net/phy/mscc.c) still enables that feature. This results in a mismatch => no traffic.
This patch is a copy-paste of the Ethernet device tree nodes from Linux, which resolves that issue. The device tree update also renames the Ethernet PHY labels.
Fixes: e3789a726269 ("net: dsa: felix: configure the in-band autoneg property based on OF node info")
I see the commit details now, can you please this statement in start while talking about this
Cc: Ramon Fried rfried.dev@gmail.com Signed-off-by: Vladimir Oltean vladimir.oltean@nxp.com
<snip>
Some minor comments on patch description. Rest looks fine
Reviewed-by: Priyanka Jain priyanka.jain@nxp.com