Dear Dave,
in message 58A20A281BAF1047B4EAE68DE5C0BDC2C821F5@zch01exm21.fsl.freescale.net you wrote:
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Wed 3/26/2008 7:58 AM To: Liu Dave Cc: u-boot-external; Phillips Kim Subject: Re: [PATCH V2 0/9] SATA framework and FSL SATA support patch > set
Dear Dave,
in message 1206008182.3739.6.camel@localhost.localdomain you wrote:
The patch set include two parts:
- SATA framework support
- The Freescale SATA controller support
...
Dave Liu (8): ATA: Add the support for SATA framework
Why add new support? We already have some...
[dave] really, I didn't find any SATA framework support in u-boot. if you are saying the cmd_sata.c. I don't agree it.
Your message is extremely difficult to read. Can you please use proper quoting? Please read http://www.netmeister.org/news/learn2quote.html if you need help...
board/freescale/mpc837xemds/mpc837xemds.c | 3 + common/Makefile | 1 + common/cmd_sata2.c | 206 +++++++
Can you please explain why we need a new file common/cmd_sata2.c which duplicates a lot of functions of the already existing common/cmd_sata.c ?
[dave]the common/cmd_sata.c is more likely controller specificed driver, not sata framework. the cmd_sata2.c is more generic. can connect to different SATA controller driver.
Maybe. But still both the existing common/cmd_sata.c and your new cmd_sata2.c implement the very same functions (like do_sata()) with more or less the same sub-commands etc.
I think this needs to be cleaned up. I will not accept multiple similar but conflicting implementations of the very same functions.
[dave]after the cmd_sata2.c is merge, I plan to move the cmd_sata.c to drivers/block.
Sorry, but this will not work. I will not add such duplicated code. Please add command level stuff to the (existing) common/cmd_sata.c file and do not add any new cmd_sata2.c which duplicates it. If necessary, clean up the code while you're there.
Best regards,
Wolfgang Denk