Re: [U-Boot] [PATCH v3] arm: dra7xx: Update the EXTRA_ENV_SETTINGS

On Wed, Jun 05, 2013 at 09:39:47AM -0500, Dan Murphy wrote:

Update the EXTRA_ENV_SETTING for the dra7xx. The console needs to be set to ttyO0 and the findfdt needs to be updated to load the dra7xx-evm.dtb file.

Signed-off-by: Dan Murphy dmurphy@ti.com

Did you run-time test this? I'm a little concerned about the include order, but that might turn out alright. But I think:

• "if test -z ${fdtfile}; then " \
  

Really needs to be: if test -z "${fdtfile}"; then...

So that it doesn't become: if test -z; then when fdtfile isn't set and we get a parse error there.

Thanks!