Re: [U-Boot] [PATCH] Change dead code in "test" cmd to debug output

On Friday 17 August 2012 16:56:12 Joe Hershberger wrote:

--- a/common/cmd_test.c +++ b/common/cmd_test.c

-#if 0 +#ifdef DEBUG {

• printf("test:");
  

• debug("test(%d):", argc);
  

  left = 1; while (argv[left])

• 	printf(" %s", argv[left++]);
  

• 	debug(" '%s'", argv[left++]);
  

  }

#endif

i think you can even remove the #ifdef DEBUG here since debug() will expand to nothing, and gcc should do DCE on the whole block -mike