Hi Stefano,
On Sat, Sep 23, 2017 at 5:43 AM, Stefano Babic sbabic@denx.de wrote:
Max has already fixed apalis / colibri, see for example http://patchwork.ozlabs.org/patch/817053/. I will apply Max's patches and drop 5/6 from your series. Anyway, thanks for having thought to these two boards, too.
Yes, I saw Max's patches too. When I tried the same approach on cgtqmx6eval I got build failures:
board/congatec/cgtqmx6eval/built-in.o: In function `setup_display': /home/fabio/u-boot-imx/board/congatec/cgtqmx6eval/cgtqmx6eval.c:632: undefined reference to `enable_ipu_clock' /home/fabio/u-boot-imx/board/congatec/cgtqmx6eval/cgtqmx6eval.c:633: undefined reference to `imx_setup_hdmi'
It is true that Max's patches fix the warnings for Toradex boards, but if in future someone rework the IPU code like it is done in cgtqmx6eval, then failure would happen.
So I thought that a more robust solution was to simply prevent making explicit calls to setup_display() from SPL like I did here.
This also has the benefit to have the same solution across several mx6 boards.
I am OK with Max's patches, but just wanted to provide a rationale for my proposal.
Thanks,
Fabio Estevam