Re: [U-Boot] [PATCH V4 6/8] imx: usb: There is no such register

On 19/04/2012 10:55, Timo Ketola wrote:

The reference manual of i.MX25 (nor i.MX31) does not define such register. This seems to access read only UH2_CAPLENGTH register (if CONFIG_MXC_USB_PORT is zero).

Signed-off-by: Timo Ketola timo@exertus.fi

Changes in v4:

• Rewrapped commit message

Changes in v2:

• New patch in this series

drivers/usb/host/ehci-mxc.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index 7384580..45cbd18 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -125,8 +125,6 @@ int ehci_hcd_init(void) hcor = (struct ehci_hcor *)((uint32_t) hccr + HC_LENGTH(ehci_readl(&hccr->cr_capbase))); setbits_le32(&ehci->usbmode, CM_HOST);

• setbits_le32(&ehci->control, USB_EN);
• __raw_writel(CONFIG_MXC_USB_PORTSC, &ehci->portsc); mxc_set_usbcontrol(CONFIG_MXC_USB_PORT, CONFIG_MXC_USB_FLAGS);

Acked-by: Stefano Babic sbabic@denx.de

Best regards, Stefano Babic