Re: [U-Boot] [PATCH 8/9] imx: nand: Don't invent new configuration variable

On 04/13/2012 06:21 AM, Timo Ketola wrote:

There is already CONFIG_SYS_NAND_BASE (or CONFIG_SYS_NAND_BASE_LIST) which must be defined for nand.c. Use that. nand.c sets IO_ADDR_R with that.

Signed-off-by: Timo Ketola timo@exertus.fi

drivers/mtd/nand/mxc_nand.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c index 73813a2..fcee20d 100644 --- a/drivers/mtd/nand/mxc_nand.c +++ b/drivers/mtd/nand/mxc_nand.c @@ -1361,7 +1361,7 @@ int board_nand_init(struct nand_chip *this) this->read_buf = mxc_nand_read_buf; this->verify_buf = mxc_nand_verify_buf;

• host->regs = (struct nfc_regs __iomem *)CONFIG_MXC_NAND_REGS_BASE;

• host->regs = this->IO_ADDR_R; host->clk_act = 1;

#ifdef CONFIG_MXC_NAND_HWECC

Actually, I'd rather we go the other direction and deprecate CONFIG_SYS_NAND_BASE (see CONFIG_SYS_NAND_SELF_INIT).

-Scott