Re: [U-Boot] [PATCH] led: correct off/on locations in structure

Hi Jason,

On 04/21/11 02:52, Jason Kridner wrote:

Although the initialization should probably be done with names, the existing implementation has these structures filled in the opposite order.

Signed-off-by: Jason Kridner jkridner@beagleboard.org

common/cmd_led.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/cmd_led.c b/common/cmd_led.c index 988157b..ad0fd0f 100644 --- a/common/cmd_led.c +++ b/common/cmd_led.c @@ -34,8 +34,8 @@ struct led_tbl_s { char *string; /* String for use in the command */ led_id_t mask; /* Mask used for calling __led_set() */

• void (*on)(void); /* Optional fucntion for turning LED on */
• void (*off)(void); /* Optional fucntion for turning LED on */

• void (*off)(void); /* Optional function for turning LED on */

This is a good time to also fix the comment...

• void (*on)(void); /* Optional function for turning LED on */

};

typedef struct led_tbl_s led_tbl_t;

When sending patch series, it is a good practice to number them. git format-patch -n does the job for you.