Re: [U-Boot] [PATCH 09/11] fsl_dma: Move dma function prototypes to common header file

Hi Kumar,

...

diff --git a/include/asm-ppc/fsl_dma.h b/include/asm-ppc/fsl_dma.h index c9ec6b5..06ecdcd 100644 --- a/include/asm-ppc/fsl_dma.h +++ b/include/asm-ppc/fsl_dma.h @@ -94,4 +94,9 @@ typedef struct fsl_dma { char res4[56]; } fsl_dma_t;

+#ifdef CONFIG_FSL_DMA +void dma_init(void); +int dmacpy(void *dest, const void *src, size_t n); +#endif

#ifdef protection here seems kinda pointless

Most boards won't have CONFIG_FSL_DMA defined, but this file will still be used in the immap_86xx.h files for padding immap_t. I figured most users won't have dma_init() or dmacpy() so the protection wouldn't hurt.

Peter