On Mon, Jan 17, 2022 at 09:51:24AM -0800, Angus Ainslie wrote:
Hi Tom,
On 2022-01-17 08:59, Tom Rini wrote:
On Mon, Jan 17, 2022 at 07:07:24AM -0800, Angus Ainslie wrote:
Initial commit of Librem5 devicetree files
Signed-off-by: Angus Ainslie angus@akkea.ca
Please note what kernel release the not -u-boot.dtsi files are a copy from, as they need to be copies and not modified, thanks.
There's an issue with adding the devicetree from the 5.16 kernel.
I get a compilation error due to a :missing .h in the devicetree files:
In file included from arch/arm/dts/imx8mq-librem5-r3.dtsi:11, from arch/arm/dts/.imx8mq-librem5.dtb.pre.tmp:6: arch/arm/dts/imx8mq-librem5.dtsi:13:10: fatal error: dt-bindings/rfkill/rfkill.h: No such file or directory 13 | #include "dt-bindings/rfkill/rfkill.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Should that get added to the u-boot source as well or should I modify the dts to remove this ?
Import the missing binding(s) in a separate commit first please.
For the kernel we also have 4 different dts files for the differences in PCB versions. For u-boot we don't need the differentiation as it deals with things like camera rotation and prox sensor sensitivity.
There's 2 ways to solve the this I think.
- just use the latest librem5 dts file which is made up of 3 different
dts(i) files. 2) have a defconfig for each of the different PCB versions.
Do you have a preference ?
Can you tell the revision at run-time? We have examples of boards that can and will include revA.dtb and revB.dtb and select the correct one at run time (and start with something that works on revA and revB).