On Tue, Jul 21, 2009 at 07:40:39PM +0200, Wolfgang Denk wrote :
######################################################################### diff --git a/Makefile b/Makefile index 25a6254..d05abd9 100644 --- a/Makefile +++ b/Makefile @@ -2807,6 +2807,18 @@ at91sam9g45ekes_config : unconfig pm9263_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91
+tny_a9260_nandflash_config \ +tny_a9260_eeprom_config \ +tny_a9260_config : unconfig
- @if [ "$(findstring _nandflash,$@)" ] ; then \
$(XECHO) "#define CONFIG_ENV_IS_IN_NAND" >>$(obj)include/config.h ; \$(XECHO) "... with environment variable in NAND FLASH" ; \- else \
$(XECHO) "#define CONFIG_ENV_IS_IN_EEPROM" >>$(obj)include/config.h ; \$(XECHO) "... with environment variable in SPI EEPROM CS1" ; \- fi;
- @$(MKCONFIG) -a tny_a9260 arm arm926ejs tny_a9260 calao at91
Do we need such verbosity? And is there really only a single environment variable as the message claims?
I just copied what's currently done for a number of at91-based boards, but fair enough, I'll remove it.
...
+int dram_init(void) +{
- gd->bd->bi_dram[0].start = PHYS_SDRAM;
- gd->bd->bi_dram[0].size = get_ram_size(PHYS_SDRAM, PHYS_SDRAM_SIZE);
- return 0;
Hm... no error checking here?
Will fix, thanks
...
diff --git a/include/configs/tny_a9260.h b/include/configs/tny_a9260.h new file mode 100644 index 0000000..1dcbb97 --- /dev/null +++ b/include/configs/tny_a9260.h
...
+#define ROUND(A, B) (((A) + (B)) & ~((B) - 1))
Please do not redefine.
Don't you get a warning message at least?
ROUND doesn't seem to be defined anywhere except in include/configs, at least in the master branch. Is there another branch where ROUND is defined in some common place, so that I rebase my patch on this ?
Regards,