On Friday 21 of September 2012 14:51:33 Marek Vasut wrote:
Dear Pavel Herrmann,
On Thursday 20 of September 2012 22:05:36 Marek Vasut wrote:
Dear Pavel Herrmann,
This core provides unified access to different block controllers (SATA, SCSI).
Description of the patch missing or is sub-par. You should work on this skill.
Signed-off-by: Pavel Herrmann morpheus.ibis@gmail.com
Makefile | 1 + drivers/blockctrl/Makefile | 42 ++++++ drivers/blockctrl/core.c | 349
+++++++++++++++++++++++++++++++++++++++++++++ include/dm/blockctrl.h
75 ++++++++++ 4 files changed, 467 insertions(+) create mode 100644 drivers/blockctrl/Makefile create mode 100644 drivers/blockctrl/core.c create mode 100644 include/dm/blockctrl.h
diff --git a/Makefile b/Makefile index e43fd9d..4420484 100644 --- a/Makefile +++ b/Makefile @@ -304,6 +304,7 @@ LIBS-y += test/libtest.o
LIBS-$(CONFIG_DM) += common/dm/libdm.o LIBS-$(CONFIG_DM) += drivers/demo/libdemo.o LIBS-${CONFIG_DM_BLOCK} += drivers/blockdev/libblockdev.o
+LIBS-${CONFIG_DM_BLOCK} += drivers/blockctrl/libblockctrl.o
${} ? What is this ?
Why not just reuse drivers/block and in drivers/block compile in the libblock.o so you don't polute the top-level makefile ? Easy as that.
to make a distinction between drivers that are converted to new API and those that are not, and to enable drivers to have the same filename for original and converted versions.
Pavel Herrmann