Re: [U-Boot] [PATCH v2 01/11] efi_loader: efi_smbios_register should have a return value

On 15 February 2018 at 00:31, Heinrich Schuchardt xypron.glpk@gmx.de wrote:

Errors may occur inside efi_smbios_register().

• Return a status code.
• Remove unused variables.
• Use constants where applicable.

Suggested-by: Simon Glass sjg@chromium.org Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de

---

v2 remove a change in unrelated code resent with this patch series

---

include/efi_loader.h | 2 +- lib/efi_loader/efi_smbios.c | 23 +++++++++++++++-------- 2 files changed, 16 insertions(+), 9 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org