Hi Jagannadha,
On Mon, Dec 31, 2012 at 4:14 AM, Jagannadha Sutradharudu Teki jagannadh.teki@gmail.com wrote:
Config and Status register reads doesn't require to set the quad enable bit, hence rd_qeb_req variable passed as 0.
Signed-off-by: Jagannadha Sutradharudu Teki jagannadh.teki@gmail.com
A few more general comments:
Please can you look at enhancing 'sf test' to support your modes. Then we can run 'sf test' and test which ones work.
I wonder if we should something to help with things like spi_flash_read_common(flash, &cmd, sizeof(cmd), (void *)data, 1);
Perhaps you should define spi_flash_xfer_byte(flash, int cmd, int *resp)
which writes a single byte command and reads a single byte response?
Regards, Simon
drivers/mtd/spi/spi_flash.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c index 15ad05c..7a15a69 100644 --- a/drivers/mtd/spi/spi_flash.c +++ b/drivers/mtd/spi/spi_flash.c @@ -293,7 +293,8 @@ int spi_flash_cmd_read_status(struct spi_flash *flash, void *data) int ret;
cmd = CMD_READ_STATUS;
ret = spi_flash_read_common(flash, &cmd, sizeof(cmd), (void *)data, 1);
ret = spi_flash_read_common(flash, &cmd, 0,sizeof(cmd), (void *)data, 1); if (ret < 0) { debug("SF: fail to read status register\n"); return ret;@@ -343,7 +344,8 @@ int spi_flash_cmd_read_config(struct spi_flash *flash, void *data) int ret;
cmd = CMD_READ_CONFIG;
ret = spi_flash_read_common(flash, &cmd, sizeof(cmd), (void *)data, 1);
ret = spi_flash_read_common(flash, &cmd, 0,sizeof(cmd), (void *)data, 1); if (ret < 0) { debug("SF: fail to read config register\n"); return ret;-- 1.7.0.4
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot