Re: [U-Boot] [PATCH v2 2/6] mx28evk: We shouldn't hardcode a rootfs filesystem type

On 28/12/2012 20:17, Otavio Salvador wrote:

For a generic environment, we shouldn't have a fixed rootfs filesystem so we drop it from env.

Signed-off-by: Otavio Salvador otavio@ossystems.com.br

Hi Otavio,

Changes in v2:

• reformat environment change to fit in 80 cols

include/configs/mx28evk.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h index 8b89b25..ac9522f 100644 --- a/include/configs/mx28evk.h +++ b/include/configs/mx28evk.h @@ -292,11 +292,9 @@ "console_mainline=ttyAMA0\0" \ "mmcdev=0\0" \ "mmcpart=2\0" \

• "mmcroot=/dev/mmcblk0p3 rw\0" \
• "mmcrootfstype=ext3 rootwait\0" \
• "mmcargs=setenv bootargs console=${console_mainline},${baudrate} " \

• "root=${mmcroot} " \
  

• "rootfstype=${mmcrootfstype}\0"	\
  

• "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \
• "mmcargs=setenv bootargs console=${console_mainline},${baudrate} "

• "root=${mmcroot}\0" \
  

  "loadbootscript=" \ "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \ "bootscript=echo Running bootscript from mmc ...; " \

I still get errors running checkpatch, for example:

WARNING: line over 80 characters #554: FILE: include/configs/mx53loco.h:162: + "if run ${get_cmd} ${ftd_addr} ${ftd_file}; then " \

WARNING: line over 80 characters #560: FILE: include/configs/mx53loco.h:168: + "echo ERROR: Cannot load the DT, aborting...; " \

WARNING: line over 80 characters #617: FILE: include/configs/mx6qsabrelite.h:177: + "if fatload mmc ${mmcdev}:${mmcpart} ${ftd_addr} ${ftd_file}; then " \

Can you fix it and resubmit, please ? I will then apply the patchset.

Thanks, Stefano Babic