Re: [U-Boot-Users] [PATCH] Common code for detecting new mpc8xx core.

31 Mar 2006


      In message 11437528013650-git-send-email-davidho@nanometrics.ca you wrote:
...
This refines the routine for detecting new mpc8xx core.
This does however add a few bytes to the initial stack usage (Implemented as a
function).
Is there any actual problem this patch is supposed to fix, or  is  it
just implemented in a different style?
I don't see any immediate reason why I should like your  code  better
than the existing one.
Also, you patch violates the Coding Style  requirements  (which,  for
example, requies to use TABs for indentation).
Best regards,
Wolfgang Denk
-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"Plan to throw one away.  You will anyway."
                              - Fred Brooks, "The Mythical Man Month"