Dear "David C. Purdy",
In message alpine.DEB.2.00.1203152035020.6790@bitbaker64 you wrote:
This patch adds support for Cloud Engines Pogoplug E02.
Information regarding the CE Pogoplug E02 board can be found at: http://archlinuxarm.org/platforms/armv5/pogoplug-v2-pinkgray
Signed-off-by: David Purdy david.c.purdy@gmail.com Cc: prafulla@marvell.com Cc: albert.u.boot@aribaud.net
Checpatch reports a large number of trailing white space errors. Please fix, and make sure to run checkpatch before resubmitting.
...
- if (miiphy_read(name, 0xEE, 0xEE, (u16 *) &devadr)) {
printf("Err..(%s) could not read PHY dev address\n",__func__);
Your patch is line-wrapped and cannot be used. Please fix your mailer setup. Ideally use git-send-email to dubmit patches.
...
+#define POGOPLUG_E02_OE_VAL_HIGH (0)
Don't use parens around simple arguments.
+/*
- max 4k env size is enough, but in case of nand
- it has to be rounded to sector size
- */
I think this is not correct.
+#define CONFIG_ENV_SIZE 0x20000 /* 128k */
If it was correct, you should use CONFIG_ENV_SECT_SIZE instead of a hard-wired constant which might be wrong.
+#define CONFIG_ENV_ADDR 0x60000 +#define CONFIG_ENV_OFFSET 0x60000 /* env starts here */
Using both ADDR and OFFSET is redundant at best. Drop one.
+#define CONFIG_EXTRA_ENV_SETTINGS \
- "mtdparts=mtdparts=orion_nand:1M(u-boot),4M(uImage)," \
...
- "mtdids=nand0=orion_nand\0"\
Orion ?
Best regards,
Wolfgang Denk