
Hi Patrick,
On 22 November 2016 at 06:24, Patrick Delaunay patrick.delaunay73@gmail.com wrote:
From: Patrick Delaunay patrick.delaunay@st.com
Signed-off-by: Patrick Delaunay patrick.delaunay@st.com Signed-off-by: Patrick Delaunay patrick.delaunay73@gmail.com
Kconfig | 12 ++ cmd/gpt.c | 98 ++++++++-- cmd/mtdparts.c | 103 ++++++++++- cmd/part.c | 48 ++++- disk/part_efi.c | 526 ++++++++++++++++++++++++++++++++++++++++++++++++----- doc/README.gpt.mtd | 189 +++++++++++++++++++ include/part.h | 13 +- include/uuid.h | 1 + lib/uuid.c | 33 ++++ 9 files changed, 944 insertions(+), 79 deletions(-) create mode 100644 doc/README.gpt.mtd
General comments:
- use 'U-Boot' consistently rather than variations - can you split your large function up a bit? - can you make a precursor patch to refactor things, so reducing the size of this one? - nice README!
diff --git a/Kconfig b/Kconfig index 1263d0b..c2388e1 100644 --- a/Kconfig +++ b/Kconfig @@ -335,6 +335,18 @@ config ARCH_FIXUP_FDT
endmenu # Boot images
+config EFI_PARTITION_MTD
bool "Support GPT over MTD"
help
The GPT partition is normally defined only for block device with
built-in controller which manage flash translation layer
This option activate the GPT partition support over RAW device
using the MTD framework
- manage partition over MTD devices (as flash: NOR and NAND)
- extract MTD information
- update command gpt, mtdparts and part
NB: depends on EFI_PARTITION
So do you want 'depends on EFI_PARTITION'?
Regards, Simon