On 30/03/2019 21:18, Simon Glass wrote:
On Fri, 22 Mar 2019 at 19:32, Andre Przywara andre.przywara@arm.com wrote:
Hi Simon,
many thanks for the review of all those patches, much appreciated!
So far arrows key pressed on an USB keyboard got translated to some low ASCII control sequences (Ctrl+N, Ctrl+P). Some programs understand these codes, but the standard for those keys is to use ANSI control
Which standard?
The only real standard for encoding arrow keys seems to be "ANSI terminal" escape sequences, I think ECMA-48 is the official name(?) Also since our very own U-Boot boot menu requires this ...
Cheers, Andre
sequences for cursor movement (ESC [ A). Our own boot menu is a victim of this, currently we cannot change the selection with an USB keyboard due to this.
Since we already implement a queue for USB key codes, we can just insert the three character ANSI sequence into the key buffer. This fixes the bootmenu, and is more universal for other users (UEFI) as well.
Signed-off-by: Andre Przywara andre.przywara@arm.com
common/usb_kbd.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org