Hi Ilias,
On Tue, 26 Nov 2024 at 01:01, Ilias Apalodimas ilias.apalodimas@linaro.org wrote:
Hi Simon,
On Mon, 25 Nov 2024 at 22:45, Simon Glass sjg@chromium.org wrote:
One of the confusing parts of the EFI loader is that it uses u64 for addresses, whereas the rest of U-Boot typically uses ulong.
There is a case on 32-bit machines where phys_addr_t can be larger than 32 bits, but this is very much the exception. Also, such machines have mostly faded away and generally don't make use of EFI.
I am not sure how true this statement is with LPAE etc. In any case, I don't want us to convert to ulong, there's no reason to break things for platforms we can't test. So please drop this patch
Yes, I believe LPAE (only on 32-bit machines) is the exception i am aware of. But U-Boot doesn't make use of the MMU for this, right? So do we need to worry about this?
This patch is not essential to the goal here, but I would like to make use of ulong for addresses, since it removes the sort of confusion that we have with EFI at present.
Thanks /Ilias
So in the interests of consistency, update the memory functions to use ulong in most cases.
Signed-off-by: Simon Glass sjg@chromium.org
include/efi_loader.h | 4 ++-- lib/efi_loader/efi_memory.c | 42 ++++++++++++++++++------------------- 2 files changed, 23 insertions(+), 23 deletions(-)
[..]
Regards, SImon