-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Hi Simon,
On 16.12.2015 23:29, Simon Glass wrote:
Hi Mateusz,
On 10 December 2015 at 14:41, Mateusz Kulikowski mateusz.kulikowski@gmail.com wrote:
[...]
diff --git a/arch/arm/mach-snapdragon/clock-apq8016.c b/arch/arm/mach-snapdragon/clock-apq8016.c new file mode 100644 index 0000000..c8c15b4 --- /dev/null +++ b/arch/arm/mach-snapdragon/clock-apq8016.c
Can this go in drivers/clk?
Yes, it can, but it's very SoC specific (at least for now). That is - it will probably work only on 2 devices (APQ8016 and MSM8916).
[...]
+++ b/arch/arm/mach-snapdragon/include/mach/gpio.h
Should this go in a different patch? I thought you had a GPIO driver earlier?
Ouch... yeah, this should definitely go to msm_gpio
[...]
+#define _MACH_APQ8016_SYSMAP_H
+#define GICD_BASE 0x0b000000 +#define GICC_BASE 0x0a20c000
Do you need these? Perhaps they can go in the device tree?
Nope, at least not for now.
It's required by armv8/start.S so must go either to board file or here :(
Regards, Mateusz