22 Mar
2013
22 Mar
'13
10:17 p.m.
Dear York Sun,
In message 514CC7B1.2070706@freescale.com you wrote:
Will fix. I often found unsure about some warnings, not knowing if u-boot follow exactly the same standard. Beside, some old patches may pass checkpatch then but fails today.
Well, you are supposed to run checkpatch _today_, before posting, and fix such issues.
There may be a few cases where you intentionally ignore such fixes (like lines over 80 characters in tables of pin-muxc initializations, where wrapping the code would make it even worse to read), but such exceptions and your reasoning should be metioned in the comments.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
An Elephant is a mouse with an Operating System. - Knuth