Dear Wolfgang Denk, In message 20120623123302.5ABCA2000F1@gemini.denx.de you wrote:
Dear Dmitry Bondar,
In message 1340449870-26456-1-git-send-email-bond@inmys.ru you wrote:
C6X (C6000) is family of fixed and floating-point DSPs manufactured by Texas Instruments.
Signed-off-by: Dmitry Bondar bond@inmys.ru Cc: Tom Rini trini@ti.com
Changes for v2:
- davinci SOC reset_c.c rewritten with readl/writel.
- Tom Rini trini@ti.com added to cc
Please run your patches through checkpatch and fix the issues. Then try and resubmit:
( tools/checkpatch.pl out removed )
After rework, code in arch/c6x tools/checkpatch.pl 0001-Add-support-new-arch-c6x.patch tell me: "total: 0 errors, 39 warnings, 3065 lines checked" can i try send patch to list, or if not, what i must do with typedefs of global_data, volatile in asm/io.h and __kernel... types in asm/posix_types.h (all other arch has same code)?
tools/checkpatch.pl out now: $ tools/checkpatch.pl 0001-Add-support-new-arch-c6x.patch WARNING: do not add new typedefs #306: FILE: arch/c6x/include/asm/global_data.h:36: +typedef struct global_data {
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #364: FILE: arch/c6x/include/asm/global_data.h:94: +#define DECLARE_GLOBAL_DATA_PTR register volatile gd_t *gd asm ("B31")
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #394: FILE: arch/c6x/include/asm/io.h:14: +#define readb(addr) (*(volatile unsigned char *) (addr))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #395: FILE: arch/c6x/include/asm/io.h:15: +#define readw(addr) (*(volatile unsigned short *) (addr))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #396: FILE: arch/c6x/include/asm/io.h:16: +#define readl(addr) (*(volatile unsigned int *) (addr))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #398: FILE: arch/c6x/include/asm/io.h:18: +#define writeb(b, addr) ((*(volatile unsigned char *) (addr)) = (b))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #399: FILE: arch/c6x/include/asm/io.h:19: +#define writew(b, addr) ((*(volatile unsigned short *) (addr)) = (b))
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #400: FILE: arch/c6x/include/asm/io.h:20: +#define writel(b, addr) ((*(volatile unsigned int *) (addr)) = (b))
WARNING: do not add new typedefs #463: FILE: arch/c6x/include/asm/posix_types.h:18: +typedef unsigned int __kernel_dev_t;
WARNING: do not add new typedefs #464: FILE: arch/c6x/include/asm/posix_types.h:19: +typedef unsigned long __kernel_ino_t;
WARNING: do not add new typedefs #465: FILE: arch/c6x/include/asm/posix_types.h:20: +typedef unsigned long long __kernel_ino64_t;
WARNING: do not add new typedefs #466: FILE: arch/c6x/include/asm/posix_types.h:21: +typedef unsigned int __kernel_mode_t;
WARNING: do not add new typedefs #467: FILE: arch/c6x/include/asm/posix_types.h:22: +typedef unsigned int __kernel_nlink_t;
WARNING: do not add new typedefs #468: FILE: arch/c6x/include/asm/posix_types.h:23: +typedef long __kernel_off_t;
WARNING: do not add new typedefs #469: FILE: arch/c6x/include/asm/posix_types.h:24: +typedef long long __kernel_loff_t;
WARNING: do not add new typedefs #470: FILE: arch/c6x/include/asm/posix_types.h:25: +typedef int __kernel_pid_t;
WARNING: do not add new typedefs #471: FILE: arch/c6x/include/asm/posix_types.h:26: +typedef unsigned short __kernel_ipc_pid_t;
WARNING: do not add new typedefs #472: FILE: arch/c6x/include/asm/posix_types.h:27: +typedef unsigned int __kernel_uid_t;
WARNING: do not add new typedefs #473: FILE: arch/c6x/include/asm/posix_types.h:28: +typedef unsigned int __kernel_gid_t;
WARNING: do not add new typedefs #474: FILE: arch/c6x/include/asm/posix_types.h:29: +typedef unsigned int __kernel_size_t;
WARNING: do not add new typedefs #475: FILE: arch/c6x/include/asm/posix_types.h:30: +typedef int __kernel_ssize_t;
WARNING: do not add new typedefs #476: FILE: arch/c6x/include/asm/posix_types.h:31: +typedef int __kernel_ptrdiff_t;
WARNING: do not add new typedefs #477: FILE: arch/c6x/include/asm/posix_types.h:32: +typedef long __kernel_time_t;
WARNING: do not add new typedefs #478: FILE: arch/c6x/include/asm/posix_types.h:33: +typedef long __kernel_suseconds_t;
WARNING: do not add new typedefs #479: FILE: arch/c6x/include/asm/posix_types.h:34: +typedef long __kernel_clock_t;
WARNING: do not add new typedefs #480: FILE: arch/c6x/include/asm/posix_types.h:35: +typedef int __kernel_daddr_t;
WARNING: do not add new typedefs #481: FILE: arch/c6x/include/asm/posix_types.h:36: +typedef char *__kernel_caddr_t;
WARNING: do not add new typedefs #482: FILE: arch/c6x/include/asm/posix_types.h:37: +typedef unsigned short __kernel_uid16_t;
WARNING: do not add new typedefs #483: FILE: arch/c6x/include/asm/posix_types.h:38: +typedef unsigned short __kernel_gid16_t;
WARNING: do not add new typedefs #484: FILE: arch/c6x/include/asm/posix_types.h:39: +typedef unsigned int __kernel_uid32_t;
WARNING: do not add new typedefs #485: FILE: arch/c6x/include/asm/posix_types.h:40: +typedef unsigned int __kernel_gid32_t;
WARNING: do not add new typedefs #487: FILE: arch/c6x/include/asm/posix_types.h:42: +typedef unsigned short __kernel_old_uid_t;
WARNING: do not add new typedefs #488: FILE: arch/c6x/include/asm/posix_types.h:43: +typedef unsigned short __kernel_old_gid_t;
WARNING: do not add new typedefs #491: FILE: arch/c6x/include/asm/posix_types.h:46: +typedef struct {
WARNING: do not add new typedefs #942: FILE: arch/c6x/include/asm/types.h:4: +typedef unsigned short umode_t;
WARNING: do not add new typedefs #986: FILE: arch/c6x/include/asm/types.h:48: +typedef unsigned long phys_addr_t;
WARNING: do not add new typedefs #987: FILE: arch/c6x/include/asm/types.h:49: +typedef unsigned long phys_size_t;
WARNING: do not add new typedefs #1056: FILE: arch/c6x/include/asm/u-boot.h:39: +typedef struct bd_info {
WARNING: do not add new typedefs #2328: FILE: arch/c6x/lib/divull.c:132: +typedef union {
total: 0 errors, 39 warnings, 3065 lines checked