Re: [U-Boot] [PATCH v3] dm/mmc: gen_atmel_mci: Add driver model support for mci

On 24 January 2017 at 22:15, Wenyou Yang wenyou.yang@atmel.com wrote:

Add the driver model support for Atmel mci while retaining the existing legacy code. This allows the driver to support boards that have converted to driver model as well as those that have not.

Signed-off-by: Wenyou Yang wenyou.yang@atmel.com

Changes in v3:

• Use unified #ifdef CONFIG_DM_MMC #else...#endif, instead of #ifndef CONFIG_DM_MMC #else...#endif.

Changes in v2:

• Change the return type of atmel_mci_setup_cfg() from int to void.
• Add comments on the features depends on the IP version.
• Add the error handle path of clock.
• Fix the missing use priv->bus_clk_rate.
• Return from mmc_bind() directly, instead of checking its return.

drivers/mmc/Kconfig | 9 +++ drivers/mmc/gen_atmel_mci.c | 164 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 172 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass sjg@chromium.org