Re: [U-Boot] [PATCH V2 2/5] ARM: Add Support for Marvell Pantheon Familiy SoCs

Dear Lei Wen,

In message AANLkTin0HQKxKiLas8H4_GHmFsdi1Mt3gPbTK0A17r2d@mail.gmail.com you wrote:

...

...

•   while (loop--);
  

Please write:

       while (loop--)
                   ;

Fixed...

...

But then - are you sure the compiler does not optimize this out? You probably want to use __udelay() instead.

From the practice, we think this loop is enough to make timer stablize...

There is nothing in this code to prevent the cmpiler from optimizing this out.

You can as well delete these lines then.

If you need a delay, then you must do better.

Involve the __udelay() may not suitable for the timer functions...

Depends...

Best regards,

Wolfgang Denk