Re: [U-Boot] [PATCH] dm: ppc: Fixup cpu.c warning in mpc8xx

Dear Marek Vasut,

In message 1343419212-18716-1-git-send-email-marex@denx.de you wrote:

cpu.c: In function ‘check_CPU’: cpu.c:256:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

Signed-off-by: Marek Vasut marex@denx.de Cc: Wolfgang Denk wd@denx.de

---

arch/powerpc/cpu/mpc8xx/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

...

• k = (immr << 16) | *((ushort *) & immap->im_cpm.cp_dparam[0xB0]);

• k = (immr << 16) | readw(&immap->im_cpm.cp_dparam[0xB0]);

I think this is wrong. readw() is a little endian I/O accessor, but PPC is all big-endian.

Guess this was untested?

Best regards,

Wolfgang Denk