23 Mar
2006
23 Mar
'06
1:01 a.m.
In message E3B2BA58-2FB1-4DAA-BC28-03091A49D02E@kernel.crashing.org you wrote:
Should this really go into the generic flat dev tree code?
I don't think so.
If nothing else this shouldn't be in cpu/mpc85xx/cpu.c but in board code. You are assuming the layout of the memory/reg property will only be a single value which is necessarily true. It would be
----^---- "not" missing here, I guess.
completely reasonable to have the memory/reg represent each bank of memory as a unique pair in the reg property. I believe this is what Apple does in its OF.
Best regards,
Wolfgang Denk
--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The games have always strengthened us. Death becomes a familiar
pattern. We don't fear it as you do.
-- Proconsul Marcus Claudius, "Bread and Circuses",
stardate 4041.2