On Thu, 8 Nov 2012 11:48:54 +0100 Wolfgang Denk wd@denx.de wrote:
In message 1351553687-12469-10-git-send-email-kim.phillips@freescale.com you wrote:
...
Signed-off-by: Kim Phillips kim.phillips@freescale.com
Has anybody tested the impact of this change on the memory footprint?
without this commit, a P4080DS build yields:
text data bss dec hex filename 404934 14340 280400 699674 aad1a ./u-boot
with this commit:
text data bss dec hex filename 398593 19896 280400 698889 aaa09 ./u-boot
so basically it's a tiny improvement overall. The U_BOOT_CMD changes moved the help text from the .rodata section into the .data section (text).
I object against the implementation.
The whole idea of the U_BOOT_CMD() macro was to be able to write command entries in a _convenient_ way. This patch makes this worse.
Please fix this such that we do NOT have to do all this ugly manual encoding of the help texts.
it's only in the case of long help text that changes with configurations, and I'm not sure on how it can be avoided.
Note also that this patch implements quite a few pretty much different changes - these should be split into separate commits.
it's been applied already, but I can resubmit as a series by sparse error type if you want to revert it (it does so cleanly).
Kim