On Mon, Mar 16, 2015 at 10:11:17AM -0700, York Sun wrote:
On 03/16/2015 10:05 AM, Tom Rini wrote:
8xx and 83xx just need the dummy files copied over.
OK, I went and poked at going one direction on this and then dug into the higher level problem more. PowerPC _needs_ the current kernel's arch/powerpc/kernel/misc_32.S relevant cache functions ported over for everyone and we should kill the dummy functions we have today. To try and encourage some folks to do this I'm going to drop this bootcount patch for now.
FWIW, powerpc mpc83xx, mpc85xx, mpc86xx all have flush_dcache_range() function defined.
Yes and no: $ git grep -l flush_dcache_range arch/powerpc/ arch/powerpc/cpu/mpc512x/cache.c arch/powerpc/cpu/mpc5xxx/cache.c arch/powerpc/cpu/mpc83xx/cache.c arch/powerpc/cpu/mpc85xx/cache.c arch/powerpc/cpu/mpc86xx/cache.S arch/powerpc/cpu/ppc4xx/cache.S
Of these only ppc4xx and mpc86xx are real functions, borrowed from the kernel long long ago. The rest are dummy functions. And we should instead make everyone have the same real functions the kernel does :)
Ah! I was under the impression we use it. But we actually used flush_cache() function.
Yeah, there's some related cleanup that should be done too :)