Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090614092233.GE22856@game.jcrosoft.org you wrote:
Is this new invented code, or is this in any way an adaption of exiting code, like the menu interface as used on the Openmoko Freerunner etc. ?
new code that I write myself why?
This is bad. Re-inventing the wheel again and again does not make it better.
I write what I need
So do I. And I write it from scratch when I cannot find existing code that does what I need, or that I consider unacceptable for other easons. But whenever I find existing soplutions I try to reuse them. That's the core idea of software engineering.
May I please ask you to read it now, and either adapt it or come up with a compatible implementation?
I'd rather see convergence and consolidation (i. e. pulling out-of-tree features into mainline) instead of ever growing divergence.
why? They have no wish to come mainline.
But you do.
I'll no adapt the API I use for my own need to match theirs If they want to use it they can do it but I'll not do the effort for them
And I hereby state that I will not accept any new menu system code into U-Boot mainline until it has been at least checked if there is a way to unify this with the Openmoko approach.
You prefer your own code, so please prove that it is so much better than the Openmoko code. Otherwise your efforts would be better invested in pulling their code into mainline, and extending / adap- ting it such that it fits your purposes.
Best regards,
Wolfgang Denk