On Sun, 2 Feb 2020 at 23:52, Wolfgang Denk wd@denx.de wrote:
Dear Nathan,
In message 20200202130227.7755-1-nathan@nathanrossi.com you wrote:
When CONFIG_SPL_ENV_SUPPORT is disabled, nvedit was still being included as part of the build. Use the CONFIG_ENV_SUPPORT, CONFIG_SPL_ENV_SUPPORT or CONFIG_TPL_ENV_SUPPORT values to enable/disable the inclusion of nvedit.
Why should the availability of these commands depend on any of these settings? I think this is wrong - whether someone wants to have environment commands in SPL or TPM is an independent decision. You must not dictate it in such a way for all users.
This file is dependent on code from env/, specifically code that is conditional on the various ENV_SUPPORT configs. As the underlying compilation issue stems from nvedit providing what appears to be common environment code (e.g. env_get), it made sense to have nvedit conditional on the same config.
Regards, Nathan