On 13/12/18 1:55 AM, Jagan Teki wrote:
On Wed, Dec 12, 2018 at 11:08 PM Vignesh R vigneshr@ti.com wrote:
Add non DM version of SPI_MEM to support easy migration to new SPI NOR framework. This can be removed once DM_SPI conversion is complete.
Our intention to use new driver to follow dm, why we need to support non-dm? any usecases?
As said by others, AFAICS, DM_SPI migration is not going to be complete anytime soon. There are many boards and configs that don't enable DM_SPI. I propose you add a patch to print _warning during build_ for boards that don't have DM_SPI enabled (like DM_MMC and DM_USB) targeting v2019.07 or v2019.04 as deadline for removal. At the deadline you can remove spi-mem-nodm.c along with all other non DM code in SPI core.
Else, I need to reintroduce code that uses wrappers in sf.c which means two separate code paths/logics in spi-nor-core.c that adds to SPL code size
I don't think it makes sense to block new development for majority of folks who are already migrated to DM_SPI. If we end up completing DM_SPI migration before merging this series, this patch can be dropped w/o any side effects.