On Mon, Jul 12, 2010 at 7:22 PM, Scott Wood scottwood@freescale.com wrote:
Change if (ok) { bunch of stuff } else { error }
to
if (error) { get out }
proceed with bunch of stuff
Plus a few whitespace cleanups.
Signed-off-by: Scott Wood scottwood@freescale.com
Applied to u-boot-nand-flash
Thank you for taking the patch [1] despite all the problems. I'm making note of all of them so I don't do it again.
I made sure that everything is still working, just to be safe. I started with a NAND flash that was using the old byte-offset marker and then moved to the new marker. Both work as expected.
U-Boot > nand dump.oob 0 Page 00000000 dump: OOB: ff ff 45 4e 56 30 00 00 08 00 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff U-Boot > nand env.oob get 0x00080000 U-Boot > nand env.oob set 0x80000 U-Boot > nand dump.oob 0 Page 00000000 dump: OOB: ff ff 45 56 42 30 04 00 00 00 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff U-Boot > nand env.oob get 0x00080000
I guess it doesn't matter since it has already been applied, but here's my tag anyways.
Tested-by: Ben Gardinerbengardiner@nanometrics.ca
Thank you again for cleaning up the patch. Best Regards,
Ben Gardiner
[1] http://git.denx.de/?p=u-boot/u-boot-nand-flash.git;a=commit;h=c9f7351b5bb70d...
--- Nanometrics Inc. +1 (613) 592-6776 x239 http://www.nanometrics.ca