Hi Eugeniu,
Hello Petr,
On Sat, May 12, 2018 at 08:25:56PM +0200, Petr Vorel wrote:
When applied all 6 patches, I got several errors (see bellow). I tested in on 2 distros (Debian unstable and openSUSE Tumbleweed). The code I applied is here, did I make error when applying patches? https://github.com/pevik/u-boot/tree/eugeniu/kconfig.v2
I checked your branch and got some interesting conclusions. Here is the diff between my and your version of commit ("kconfig: re-sync with Linux 4.17-rc4"):
$ git diff <eugeniu> <petr> scripts/kconfig/tests/auto_submenu/expected_stdout | 14 +++++++------- scripts/kconfig/tests/choice/oldask0_expected_stdout | 14 +++++++------- scripts/kconfig/tests/choice/oldask1_expected_stdout | 12 ++++++------ scripts/kconfig/tests/new_choice_with_dep/expected_stdout | 4 ++-- 4 files changed, 22 insertions(+), 22 deletions(-)
Here is the same diff ignoring whitespace:
$ git diff -w <eugeniu> <petr> scripts/kconfig/tests/auto_submenu/expected_stdout | 0 scripts/kconfig/tests/choice/oldask0_expected_stdout | 0 scripts/kconfig/tests/choice/oldask1_expected_stdout | 0 scripts/kconfig/tests/new_choice_with_dep/expected_stdout | 0 4 files changed, 0 insertions(+), 0 deletions(-)
So, it seems like all the trailing white-space from above files disappeared on your branch, after applying the patches from the email client (who did this?...).
OK, my fault, I'm sorry. Applying first patch as 'git am --whitespace=warn 1.mbox' fixes that => make testconfig works.
Yes I applied patches with mutt (I usually use pwclient, but somehow I didn't find your v2 in patchwork [1], nor even in ML [2]. Have I overlook something.
[1] https://patchwork.ozlabs.org/project/uboot/list/ [2] https://lists.denx.de/pipermail/u-boot/2018-May/date.html
Kind regards, Petr
I didn't expect that trailing white-space to be of any value for the test results, but it turns out it is! With the whitespace removed, I can also reproduce the failures of "make testconfig".
I am not familiar with pytest, but, based on what we see here, it looks like every single character stored in *xpected_stdout files (including whitespace at the end of lines) matters for the test to pass.
I wonder if Kconfig could avoid printing whitespace in command line user dialogs. Then maybe those space characters could be removed from the "*xpected_stdout" files.
Masahiro?
Thanks again!
Best regards, Eugeniu.