Re: [U-Boot] [PATCH v2 0/3] Add Ethernet support for Poplar board

4 Mar 2019

      On Mon, Feb 18, 2019 at 11:37:39AM +0800, Shawn Guo wrote:
...
The series adds Ethernet support for Poplar board.  It firstly creates
a reset driver for HiSilicon platform, then introduces higmacv300
Ethernet driver, and finally enables Ethernet support for Poplar board.
Changes for v2:

Rename driver symbol to HIGMACV300_ETH.
Remove the use of temp variable 'addr' in higmac_recv().
Simplify the return of function higmac_ofdata_to_platdata() and
higmac_probe().
Combine delaration and initialization for phyintf in function
higmac_ofdata_to_platdata().
Eliminate the MDIO read/write macros.
Use wait_for_bit_le32() for MDIO command completion polling.
Set up RX packet buffers in RX_FQ descriptor at initialization time,
so that we do not need to allocate/free packet buffers repeatedly.
Inform GMAC that the RX descriptor is no longer in use in function
higmac_free_pkt().
Define BITS_DESC_ENA instead of using magic number 0xf.

Hi Joe,
Does this version look good to you?
Shawn