Hello,
On 10/27/2014 07:48 PM, Simon Glass wrote:
Hi Przemyslaw,
On 24 October 2014 09:44, Przemyslaw Marczak p.marczak@samsung.com wrote:
Hello Simon, Tom,
The last driver-model changes was merged too fast and I was not able to test it well on all my boards. It was worked well for the first look, but after deep testing - it required some additional work to do.
So this is a set of fixes required for Exynos4xxx boards. I am not sure what about the Origen.
The patchset was rebased on the top of u-boot-dm/master, which is now: c2ded96 serial: remove uniphier_serial_initialize() call
Tested on:
- Trats (E4210)
- UniversalC210 (E4210)
- Trats2 (E4412)
- Odroid U3 (E4412)
- Odroid X2 (E4412)
Actually I never did update the device tree numbering so I suspect this series has been incorrect since version 1! Since exynos5 was always sequential I somehow missing thinking about it. This is great, thanks for straightening it all out and testing. Particularly I am pleased about Universal since the soft SPI was a bit of a poke in the dark.
I'll go through this soon. I was also planning to send a patch to clean up some of the gpio_name_num_table stuff since it shouldn't be needed any more.
Regards, Simon
Yes, probably some bugs, was there before the last changes. But the main issue was, that after remove the gaps in gpio enums, the pinmux and the spl(if used) configured some wrong registers. Now this should works. I have some other task now, so the rest of unmerged patches I will resend today evening. Thank you for the review, and I hope that I didn't break any Exynos5 board?
Best regards,