Re: [U-Boot] [PATCH v5] bitops: introduce BIT() definition

Dear Andreas,

In message 1441626234-16364-1-git-send-email-andreas.devel@googlemail.com you wrote: ...

--- a/include/linux/bitops.h +++ b/include/linux/bitops.h @@ -3,6 +3,8 @@

#include <asm/types.h>

+#define BIT(nr) (1UL << (nr))

What happens when someone decides to use this on a 64 bit register?

Also, this definition is inherently wrong for Power Architecture (TM) systems, where bit 0 is the most significant bit.

Best regards,

Wolfgang Denk