Mashiro,
-----Original Message----- From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com] Sent: Wednesday, January 04, 2017 3:07 AM To: Tom Warren TWarren@nvidia.com; Marcel Ziswiler marcel@ziswiler.com; Marcel Ziswiler marcel.ziswiler@toradex.com Cc: u-boot@lists.denx.de; Lucas Stach dev@lynxeye.de; Joe Hershberger joe.hershberger@ni.com; Max Krummenacher max.krummenacher@toradex.com; Jagan Teki jteki@openedev.com; Stefan Roese sr@denx.de; Stephen Warren swarren@nvidia.com; Ian Campbell ijc@hellion.org.uk; tomcwarren3959@gmail.com; Stefan Agner stefan.agner@toradex.com; Hans de Goede hdegoede@redhat.com; Albert Aribaud albert.u.boot@aribaud.net; Alban Bedel alban.bedel@avionic-design.de; Jaehoon Chung jh80.chung@samsung.com Subject: Re: [U-Boot] [PATCH v3 0/6] arm: tegra: apalis-tk1, mmc and ext clock loopback
2017-01-04 4:40 GMT+09:00 Tom Warren TWarren@nvidia.com:
Marcel,
-----Original Message----- From: Marcel Ziswiler [mailto:marcel@ziswiler.com] Sent: Wednesday, December 21, 2016 9:26 PM To: u-boot@lists.denx.de Cc: Max Krummenacher max.krummenacher@toradex.com; Stefan Agner stefan.agner@toradex.com; Marcel Ziswiler marcel.ziswiler@toradex.com; York Sun york.sun@nxp.com; Peter.Chubb@data61.csiro.au; Lokesh Vutla lokeshvutla@ti.com; Jaehoon Chung jh80.chung@samsung.com; Hans de Goede hdegoede@redhat.com; Heiko Schocher hs@denx.de; Albert Aribaud albert.u.boot@aribaud.net; Prabhakar Kushwaha prabhakar.kushwaha@nxp.com; Stephen Warren swarren@nvidia.com; Jagan Teki jteki@openedev.com; Alexander Graf agraf@suse.de; Tom Warren TWarren@nvidia.com; Joe Hershberger joe.hershberger@ni.com; Lucas Stach dev@lynxeye.de; Allen Martin AMartin@nvidia.com; Stefan Roese sr@denx.de; Alban Bedel alban.bedel@avionic-design.de; Simon Glass sjg@chromium.org; Masahiro Yamada yamada.masahiro@socionext.com; Ian Campbell ijc@hellion.org.uk Subject: [PATCH v3 0/6] arm: tegra: apalis-tk1, mmc and ext clock loopback
From: Marcel Ziswiler marcel.ziswiler@toradex.com
This series adds support for the Toradex Apalis TK1 as well as moves the CONFIG_TEGRA_MMC to Kconfig and introduces a new option to disable the external clock loopback on SDMMC3.
The whole series is also available here:
http://git.toradex.com/cgit/u-boot-toradex.git/log/?h=for-next
Changes in v3:
- My recent fresh install of Fedora 25 was missing an aarch64 toolchain which made moveconfig.py not properly handle the 6 newer Tegras. I now re-run moveconfig.py after installing an aarch64 toolchain and it all looks sane. Sorry about that, Tom.
With Mashiro's recent 'mmc: move more driver config options to Kconfig'
patchset (which is in TOT U-Boot now), your v3 patchset no longer applies cleanly.
I'll rebase u-boot-tegra/master against u-boot/master and push a new repo to
Denx so you can get your Apalis-TK1 patchset to work w/all of the recent changes.
Thanks, and sorry for the extra work!
(Sorry, the previous mail had been sent before I completed it)
Marcel,
Sorry, I did not notice you were moving CONFIG_TEGRA_MMC.
Moreover, I am moving CONFIG_TEGRA_MMC and renaming in the following patch:
http://patchwork.ozlabs.org/patch/710054/
My goal is all MMC driver options prefixed with CONFIG_MMC_. (and SDHCI variants with CONFIG_MMC_SDHCI_, DesignWare variants with CONFIG_MMC_DW_ )
Here is a question about the Tegra MMC driver.
From the compatible strings in drivers/mmc/tegra-mmc.c, I suspect this driver is based on SDHCI and in Linux, the option name is CONFIG_MMC_SDHCI_TEGRA.
Why doesn't the driver re-use driver/mmc/sdhci.c ?
I created the tegra_mmc.c driver for Seaboard/Tegra20 way back in May of 2011 (commit 21ef6a1). I don't remember what I based it on - I assume another extant U-Boot mmc driver like mmc.c from Andy Fleming. It looks like Lei Wen created the sdhci.c driver in June of 2011 (commit af62a557), so it wasn't available when I created tegra_mmc.c.
It's unlikely that we'll take a working driver and rewrite it based on sdhci.c. If someone else wants to shoulder that burden, and does adequate testing to prove its fully compatible across all Tegra chipsets (including owning any future work), I won't object.
Tom -- nvpublic
-- Best Regards Masahiro Yamada