Hi,
It is a rebased V2 version of the serie [1].
This serie adds a lot of new #if and doesn't respect the last U-Boot coding rules with 14 warnings detected by checkpatch:
warning: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible
But I chose to copy the existing code of the fastboot files fb_command.c to a have an easier review.
So I prefer sent a patch (if it is required) to remove all the #ifdef in this file when the serie will be accepted.
I check compilation of the added features on stm32mp1 platform with the serie [2].
The compilation for modified boards (with already activated config CONFIG_FASTBOOT_MMC_BOOT1_SUPPORT) is verified with buildman:
tools/buildman/buildman mt8512_bm1_emmc mt8518_ap1_emmc pumpkin Building current source for 3 boards (3 threads, 4 jobs per thread) aarch64: w+ pumpkin +===================== WARNING ====================== +This board does not use CONFIG_DM_ETH (Driver Model +for Ethernet drivers). Please update the board to use +CONFIG_DM_ETH before the v2020.07 release. Failure to +update by the deadline may result in board removal. +See doc/driver-model/migration.rst for more info. +==================================================== aarch64: w+ mt8518_ap1_emmc +===================== WARNING ====================== +This board does not use CONFIG_DM_ETH (Driver Model +for Ethernet drivers). Please update the board to use +CONFIG_DM_ETH before the v2020.07 release. Failure to +update by the deadline may result in board removal. +See doc/driver-model/migration.rst for more info. +==================================================== aarch64: w+ mt8512_bm1_emmc +===================== WARNING ====================== +This board does not use CONFIG_DM_ETH (Driver Model +for Ethernet drivers). Please update the board to use +CONFIG_DM_ETH before the v2020.07 release. Failure to +update by the deadline may result in board removal. +See doc/driver-model/migration.rst for more info. +==================================================== 0 3 0 /3 0:00:07 : mt8512_bm1_emmc Completed: 3 total built, duration 0:00:23, rate 0.13
[1] "fastboot: mmc: Add CONFIG_FASTBOOT_MMC_USER_SUPPORT" http://patchwork.ozlabs.org/project/uboot/list/?series=200509&state=*
[2] "configs: stm32mp1: enable fastboot support of eMMC boot partition" http://patchwork.ozlabs.org/project/uboot/list/?series=200510
Regards
Patrick
Changes in v2: - rebase on master branch - new impact on pumpkin_defconfig and mt8512_bm1_emmc_defconfig - new impact on pumpkin_defconfig and mt8512_bm1_emmc_defconfig
Patrick Delaunay (4): fastboot: mmc: Add CONFIG_FASTBOOT_MMC_USER_SUPPORT fastboot: mmc: extend flash/erase for both emmc hwpart 1 and 2 fastboot: add command to select the default emmc hwpart for boot fastboot: add command to select the eMMC boot configuration
configs/mt8512_bm1_emmc_defconfig | 3 +- configs/mt8518_ap1_emmc_defconfig | 3 +- configs/pumpkin_defconfig | 3 +- doc/android/fastboot.rst | 3 ++ drivers/fastboot/Kconfig | 62 ++++++++++++++++++++------ drivers/fastboot/fb_command.c | 72 +++++++++++++++++++++++++++++++ drivers/fastboot/fb_mmc.c | 52 ++++++++++++++-------- include/fastboot.h | 6 +++ 8 files changed, 171 insertions(+), 33 deletions(-)