Hi Heiko,
Hello Tom,
added Lukasz, Marek and Felipe,
Am 18.04.2017 um 00:22 schrieb Tom Rini:
Hey all,
It's release day and v2017.05-rc2 is out. I think my patchwork queue is looking good currently. I have some outstanding removal patches to take from Masahiro related to architectures that I removed as promised. The release is bigger than I really wanted, but since I was on vacation for most of the normal -rc1 window, stuff came in that would have come in then now, instead. Things are on track for -rc3 on the 1st.
My weekly dfu test on the siemens smartweb board failed with current HEAD.
I started an automated git bisect with tbot, and found:
2017-04-19 07:24:30,717:CON :tbotlib # tb_ctrl: git bisect visualize 2017-04-19 07:24:30,783:CON :tbotlib # tb_ctrl: commit 842778a091047b0c868efa12229633959f711152 Author: Felipe Balbi felipe.balbi@linux.intel.com Date: Wed Feb 22 17:12:40 2017 +0200 usb: gadget: g_dnl: only set iSerialNumber if we have a serial#
We don't want to claim that we support a serial number string and later return nothing. Because of that, if g_dnl_serial is anempty string, let's skip setting iSerialNumber to a valid number.
This change was added recently to DFU tree. It seemed like the one, which clean up things.
Moreover, I tested it on the "old" set of DFU tests (however, those tests are not the USB compliance test suite).
Heiko, could you paste the error output? (from the host PC and the board)?
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>hs@pollux [ 7:24:30] ttbott> 2017-04-19 07:24:31,769:CON :tbotlib # tb_ctrl: git bisect log 2017-04-19 07:24:31,836:CON :tbotlib # tb_ctrl: git bisect start # bad: [f6c1df44b815a08585e7fd3805a1db51a5955d09] Prepare v2017.05-rc2 git bisect bad f6c1df44b815a08585e7fd3805a1db51a5955d09 # good: [9963890b8be1d208035945abc5ba9f77637b6542] libfdt: fix build with Python 3 git bisect good 9963890b8be1d208035945abc5ba9f77637b6542 # good: [af1b7286d8b2712cff5779d8a1565afed9d9d8e6] Merge branch 'master' of git://git.denx.de/u-boot-mmc git bisect good af1b7286d8b2712cff5779d8a1565afed9d9d8e6 # bad: [3fea95369850987de15a2a0ac009d05e13b90246] Merge branch 'master' of git://git.denx.de/u-boot-video git bisect bad 3fea95369850987de15a2a0ac009d05e13b90246 # good: [c1a16c3ab541c014b029b42cc27cae496107e170] Merge branch 'master' of git://git.denx.de/u-boot-socfpga git bisect good c1a16c3ab541c014b029b42cc27cae496107e170 # bad: [fbeb33752999e7317113199ef89873d6b6916814] buildman: Translate more strings to latin-1 git bisect bad fbeb33752999e7317113199ef89873d6b6916814 # bad: [b7bf4a95922c3e1a4974aa34ebb714ac2eb89937] usb: dwc3: ensure consistent types for dwc3_flush_cache git bisect bad b7bf4a95922c3e1a4974aa34ebb714ac2eb89937 # good: [12d0b8f5f07b76d7447d60f7528d578233553909] usb: gadget: g_dnl: hold maximum string descriptor git bisect good 12d0b8f5f07b76d7447d60f7528d578233553909 # bad: [207835b13feeae15db0555574d89352a4e5379a4] usb: gadget: g_dnl: don't set iProduct nor iSerialNumber git bisect bad 207835b13feeae15db0555574d89352a4e5379a4 # bad: [842778a091047b0c868efa12229633959f711152] usb: gadget: g_dnl: only set iSerialNumber if we have a serial# git bisect bad 842778a091047b0c868efa12229633959f711152 # first bad commit: [842778a091047b0c868efa12229633959f711152] usb: gadget: g_dnl: only set iSerialNumber if we have a serial# hs@pollux [ 7:24:31] ttbott>
Any ideas?
bye, Heiko
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de