
24 May
2014
24 May
'14
5:11 a.m.
The mask value used in itest overflows and therefore it can return an incorrect result for something like 'itest 0 == 1'. Fix it.
Signed-off-by: Simon Glass sjg@chromium.org ---
common/cmd_itest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/cmd_itest.c b/common/cmd_itest.c index ae2527b..76af62b 100644 --- a/common/cmd_itest.c +++ b/common/cmd_itest.c @@ -63,7 +63,7 @@ static long evalexp(char *s, int w) l = simple_strtoul(s, NULL, 16); }
- return (l & ((1 << (w * 8)) - 1)); + return l & ((1UL << (w * 8)) - 1); }
static char * evalstr(char *s)
--
1.9.1.423.g4596e3a