Re: [PATCH 5/5] fs: ext4: use fs_ls_generic

On Sat, 26 Oct 2024 at 08:41, Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:

Now that opendir, readir, closedir are implemented for ext4 we can use fs_ls_generic() for implementing the ls command.

Adjust the unit tests:

• fs_ls_generic() produces more spaces between file size and name.
• The ext4 specific message "** Can not find directory. **\n" is not written anymore.

Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com

fs/ext4/ext4_common.c | 29 ----------------------------- fs/ext4/ext4fs.c | 23 ----------------------- fs/fs.c | 2 +- test/py/tests/test_env.py | 2 +- test/py/tests/test_fs/test_basic.py | 5 +---- 5 files changed, 3 insertions(+), 58 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org