Re: [PATCH] board: samsung: Remove incorrect SYS_CONFIG_NAME in axy17lte Kconfig

Hi!

2023년 10월 21일 (토) 09:10, Sam Protsenko semen.protsenko@linaro.org님이 작성:

The global SYS_CONFIG_NAME in axy17lte Kconfig overrides SYS_CONFIG_NAME for all boards specified after this line in arch/arm/mach-exynos/Kconfig:

source "board/samsung/axy17lte/Kconfig"

Right now it's the last 'source' line there, so the issue is not reproducible. But once some board is moved or added after this line the next build error will happen:

  GEN     include/autoconf.mk.dep
In file included from ./include/common.h:16:
include/config.h:3:10: fatal error: configs/exynos78x0-common.h.h:
                       No such file or directory
    3 | #include <configs/exynos78x0-common.h.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

That's happening because axy17lte Kconfig defines SYS_CONFIG_NAME option in global namespace (not guarded with any "if TARGET_..."), so it basically rewrites the correct SYS_CONFIG_NAME defined in the hypothetical boards which might appear after axy17lte in mach-exynos Kconfig.

Another side of the issue is that SYS_CONFIG_NAME is defined incorrectly in axy17lte Kconfig:

config SYS_CONFIG_NAME
    default "exynos78x0-common.h"

The .h extension should not have been specified there. It's leading to the build error, as the generated include file has double '.h' extension.

Fix the issue by simply removing the SYS_CONFIG_NAME definition in axy17lte Kconfig, as all related defconfigs already declare internal values for SYS_CONFIG_NAME:

• a5y17lte_defconfig
• a7y17lte_defconfig
• a3y17lte_defconfig

Signed-off-by: Sam Protsenko semen.protsenko@linaro.org Fixes: 3e2095e960b4 ("board: samsung: add support for Galaxy A series of 2017 (a5y17lte)")

---

board/samsung/axy17lte/Kconfig | 8 -------- 1 file changed, 8 deletions(-)

diff --git a/board/samsung/axy17lte/Kconfig b/board/samsung/axy17lte/Kconfig index a018547ff5d4..209394a8a5a8 100644 --- a/board/samsung/axy17lte/Kconfig +++ b/board/samsung/axy17lte/Kconfig @@ -1,11 +1,3 @@ -config SYS_CONFIG_NAME

•   string "Board configuration name"
  

•   default "exynos78x0-common.h"
  

•   help
  

•     This option contains information about board configuration name.
  

•     Based on this option include/configs/<CONFIG_SYS_CONFIG_NAME>.h
  

header

•     will be used for board configuration.
  

if TARGET_A5Y17LTE config SYS_BOARD default "axy17lte" -- 2.39.2

This patch makes a build error since axy17lte.h was not exist. Am I miss something?

And.. actually I can't catch what you exactly fix with this patch.

Thanks. Minkyu Kang.