Re: [U-Boot] [PATCH 08/12] macb: Fix return values of macb_eth_initialize()

On Sunday 24 January 2010 05:07:46 Matthias Kaehlcke wrote:

--- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -500,7 +500,7 @@ int macb_eth_initialize(int id, void *regs, unsigned int phy_addr) macb = malloc(sizeof(struct macb_device)); if (!macb) { printf("Error: Failed to allocate memory for MACB%d\n", id);

• return -1;
  

• return 0;
  

  }

this is an error path thus the current code is correct -mike