Re: [U-Boot] [PATCH v3] Support for multiple SGMII/TBI interfaces for TSEC ethernet

15 Sep 2008


      ...
@@ -299,12 +301,10 @@ static int init_phy(struct eth_device *dev)
 {
       struct tsec_private *priv = (struct tsec_private *)dev->priv;
       struct phy_info *curphy;

  volatile tsec_t *phyregs = priv->phyregs;
 volatile tsec_t *regs = priv->regs;

 /* Assign a Physical address to the TBI */
 regs->tbipa = CFG_TBIPA_VALUE;


  phyregs->tbipa = CFG_TBIPA_VALUE;
 asm("sync");



What was the purpose of doing this?  The problem I have with it is in
the odd situation where the TSEC whose MII regs are connected to the
bus is not enabled.  It would mean that the TBIPA would never be set
to CFG_TBIPA_VALUE.
Andy

    

Andy Fleming