-----Original Message----- From: Michael Walle [mailto:michael@walle.cc] Sent: 30 March 2012 19:27 To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Wolfgang Denk Subject: Re: [PATCH v2] lsxl: add support for lschlv2 and lsxhl
Hi Prafulla,
[ I'm CCing Wolfgang on this, because i don't know who's responsible for the build/make infrastructure. ]
AFAIK, you need to pass only "u-boot.kwb" to the make (no $(okj) needed)
Sorry you're wrong here, that won't work for out-of-tree builds, see below.
Kirkwood is not only target that may need to be build for out-of-tree builds. This should be addressed for generic use case.
[mw@thanatos b-u-boot]$ LANG=C make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi- u-boot.kwb make: Entering directory `/home/mw/repo/u-boot' make: *** No rule to make target `u-boot.kwb'. Stop. make: Leaving directory `/home/mw/repo/u-boot'
- i'm only interested in the u-boot.kwb, why shouldn't it be
generated by default?
AFAIK, any target apart from u-boot.bin are optional, can be generated if needed
i can't build it with a sinlge make call. Eg. atm i'm doing
make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi-
lschlv2
otherwise i have to do
make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi-lschlv2
make -j3 -C ../u-boot O=`pwd`CROSS_COMPILE=arm-linux-gnueabi- \
`pwd`/u-boot.kwb"make u-boot.kwb CROSS_COMPILE=arm-linux-gnueabi-" generates u-boot.kwb, this should be valid with other use case too. if not, it makes sense to add an additional line in script
that a file
in code :-)
Mh, i don't understands what is wrong with a config.mk with only an additional make target? There are other boards too, which handles image generating this way (grep for ALL-y in boards/). Shouldn't be building an uboot image as simple as possible?
I understand and know this, I greped for the same but all of them have some more configuration. Anyway I am not interested to argue on this. My intention here is, this in not the only board that needs this functionaltiy. Why not to add it in generic way?
If we add .PHONY: u-boot.kwb u-boot.kwb: $(obj)u-boot.kwb to the main Makefile, i would say we should add all other image targets, too.
I would greatly appreciate is something like this can be implemented.
I'd say one could add the target to the kirkwood config.mk (if there is one per platform) but i doubt every kirkwood based board will need one (and provides a kwbimage.cfg).
FYI: all kirkwood boards as of now needs u-boot.kwb, but this is optional to any future board. I can think of adding arch/arm/cpu/arm926ejs/kirkwood/config.mk if above proposed method is not acceptable.
Regards.. Prafulla . . .