* Stephen Warren wrote:
On 05/24/2012 03:07 PM, Thierry Reding wrote:
- Stephen Warren wrote:
On 05/24/2012 01:04 AM, Thierry Reding wrote:
This adds basic USB support for port 0. Device tree support is needed to initialize the USB EHCI and will be added in a subsequent patch.
...
The code here duplicates changes made to board/nvidia/common/board.c. Shouldn't all Tegra boards be using that common board code so we don't have to duplicate all this early setup for every board vendor using Tegra? Otherwise, every time we add I2C, SPI, LP0, ... to board/nvidia/common/board.c, you'll just have to make the same change to tamonten.c too.
I think the problem is U-Boot's build system, which doesn't allow sharing code between different subdirectories of board/.
I have both board/compulab/trimslice and board/compal/paz00 sharing the board/nvidia/common code; take a look at their Makefiles.
Okay, will do.
Thierry