On 5/3/2010 3:49 PM, Tom Rix wrote:
Vipin KUMAR wrote:
On 5/3/2010 6:07 AM, Tom Rix wrote:
Vipin KUMAR wrote:
SPEAr1300 SoC support contains basic spear1300 support along with the usage of following drivers
- serial driver(UART)
- i2c driver
- smi driver
- nand driver(FSMC)
- usbd driver
<snip>
+#define CONFIG_USBD_PRODUCT_NAME "SPEAr SoC" +#define CONFIG_USBD_MANUFACTURER "ST Microelectronics"
+#define CONFIG_EXTRA_ENV_USBTTY "usbtty=cdc_acm\0"
Should be conditional on CONFIG_SPEAR_USBTTY Similar changes for spear3xx and spear6xxx
CONFIG_SPEAR_USBTTY is a special case where tty over usb terminal is used for downloading and flashing images. usbtty environment variable should normally also be set as cdc_acm to make sure that we can switch to tty over usb terminal directly from uboot prompt by simply running setenv stdout usbtty; setenv stdin usbtty
So, I am not making it conditional to CONFIG_EXTRA_ENV_USBTTY
What I mean is the extra enviroment variable and config's are dependent on USBD. It usb is not configured, these are not needed.
USBD is always configured. That's why this feature may be desirable
Tom